[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/6] block: Extract blockdev part of qmp_driv

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v2 3/6] block: Extract blockdev part of qmp_drive_mirror
Date: Mon, 20 Jul 2015 17:30:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 25.06.2015 05:22, Fam Zheng wrote:
This is the part that will be reused by blockdev-mirror.

Signed-off-by: Fam Zheng <address@hidden>
  blockdev.c | 155 ++++++++++++++++++++++++++++++++++++-------------------------
  1 file changed, 92 insertions(+), 63 deletions(-)

As you probably know (since you introduced it), this needs fixup due to 0fc9f8ea28. (And the changes are not trivial, unfortunately, so I had to give up fixing it locally.)

Generally, the set of changes looks good to me, though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]