[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location pat
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path |
Date: |
Mon, 20 Jul 2015 09:06:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 07/06/2015 10:40 PM, Michael Roth wrote:
> From: Olga Krishtal <address@hidden>
>
> According to Microsoft disk location path can be obtained via
> IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all
> devices. There are certain bus types which could be obtained with this
> API. Please, refer to the following link for more details
> https://technet.microsoft.com/en-us/library/ee851589(v=ws.10).aspx
>
> Bus type could be obtained using IOCTL_STORAGE_QUERY_PROPERTY. Enum
> STORAGE_BUS_TYPE describes all buses supported by OS.
>
> Windows defines more bus types than Linux. Thus some values have been added
> to GuestDiskBusType.
>
> Signed-off-by: Olga Krishtal <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: Michael Roth <address@hidden>
> * fixed warning in CreateFile due to use of NULL instead of 0
> Signed-off-by: Michael Roth <address@hidden>
> ---
> +++ b/qga/qapi-schema.json
> @@ -703,12 +703,24 @@
> # @uml: UML disks
> # @sata: SATA disks
> # @sd: SD cards
> +# @unknown: Unknown bus type
> +# @ieee1394: Win IEEE 1394 bus type
> +# @ssa: Win SSA bus type
> +# @fibre: Win fiber channel bus type
> +# @raid: Win RAID bus type
> +# @iscsi: Win iScsi bus type
> +# @sas: Win serial-attaches SCSI bus type
> +# @mmc: Win multimedia card (MMC) bus type
> +# @virtual: Win virtual bus type
> +# @file-backed virtual: Win file-backed bus type
> #
> # Since: 2.2
It would be nice to have a followup patch (since it is doc-only, it
could still make 2.4) that mentions that all these new enum members were
added in 2.4.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 10/10] qga: added GuestPCIAddress information, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path, Michael Roth, 2015/07/07
- Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path,
Eric Blake <=
- [Qemu-devel] [PATCH 01/10] qga/commands-posix: Fix bug in guest-fstrim, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 04/10] qga: add win32 library iphlpapi, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 02/10] qga/qmp_guest_fstrim: Return per path fstrim result, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 03/10] Revert "guest agent: remove g_strcmp0 usage", Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 06/10] qga: fail early for invalid time, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 05/10] qga: win32 qmp_guest_network_get_interfaces implementation, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality., Michael Roth, 2015/07/07
- Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0, Peter Maydell, 2015/07/07