[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 1/2] spapr: add dumpdtb support
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [RFC PATCH 1/2] spapr: add dumpdtb support |
Date: |
Mon, 20 Jul 2015 15:20:17 +0200 |
User-agent: |
Mutt/1.5.23.1 (2014-03-12) |
On Mon, Jul 20, 2015 at 02:02:33PM +1000, David Gibson wrote:
> On Fri, Jul 17, 2015 at 01:56:39PM +0200, Andrew Jones wrote:
> > Signed-off-by: Andrew Jones <address@hidden>
>
> Looks good to me, but I'd like an actual commit message: what's
> dumpdtb, how and why would you use it.
Ok, just sent it separately with a commit message and the RFC dropped.
Thanks,
drew
>
> > ---
> > hw/ppc/spapr.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index a6f19473cf278..c1cbf3387ae0c 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -30,6 +30,7 @@
> > #include "hw/fw-path-provider.h"
> > #include "elf.h"
> > #include "net/net.h"
> > +#include "sysemu/device_tree.h"
> > #include "sysemu/block-backend.h"
> > #include "sysemu/cpus.h"
> > #include "sysemu/kvm.h"
> > @@ -822,6 +823,7 @@ static void spapr_finalize_fdt(sPAPRMachineState *spapr,
> > exit(1);
> > }
> >
> > + qemu_fdt_dumpdtb(fdt, fdt_totalsize(fdt));
> > cpu_physical_memory_write(fdt_addr, fdt, fdt_totalsize(fdt));
> >
> > g_free(bootlist);
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [RFC PATCH 2/2] spapr: -kernel: allow linking with specified addr, Andrew Jones, 2015/07/21
Re: [Qemu-devel] [RFC PATCH 0/2] spapr: changes for kvm-unit-tests, David Gibson, 2015/07/20