Re: [Qemu-devel] [PATCH v4 4/5] Initial implementation of vGICv3

[Pavel Fedin]

 Hello!

> Here GICV3_INTERNAL is used, but kvm_arch_gicv3_set_irq relies on
> kvm_arm_gic_set_irq which is using GIC_INTERNAL, so the GICv3 related
> code is using both defines.

 The change relies on these definitions being equal. Ok, i agree this is a kind 
of hack and will
redo this in v5.

> As we do not have yet support for ITS implementation in QEMU the device
> tree for a GICv3 guest will have a msi-parent property in the device
> tree which will point to nothing:
> 
> "msi-parent = <0x0>"

 Oops, thank you, i forgot about this. Will fix.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia