Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

[Andreas Färber]

Am 09.07.2015 um 18:51 schrieb Cornelia Huck:
> Devices that don't live on a bus aren't caught by the normal device
> reset logic. Let's register a reset handler for those devices during
> device realization that calls the reset handler for the associated
> device class.
> 
> Suggested-by: Peter Crosthwaite <address@hidden>
> Signed-off-by: Cornelia Huck <address@hidden>
> ---
>  hw/core/qdev.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)

Looks acceptable as solution for 2.4... However, I would like to
understand why the parent device cannot reset it? Someone created that
device in the first place. I would prefer you call device_reset() from
there without this generic patch.

A similar discussion took place for the x86 APIC.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)