[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model.

From: Alexey Kardashevskiy
Subject: Re: [Qemu-devel] [PATCH] target-ppc: Add POWER8E_v2.1 CPU model.
Date: Wed, 8 Jul 2015 16:40:27 +1000
User-agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1

On 07/08/2015 03:37 PM, David Gibson wrote:
On Wed, Jul 08, 2015 at 02:10:28PM +1000, Alexey Kardashevskiy wrote:
On 07/08/2015 01:43 PM, David Gibson wrote:
From: Andrea Bolognani <address@hidden>

Add a missing PVR value for the POWER8E v2.1 CPU.  Information taken
>from the kernel cputable.

Signed-off-by: Andrea Bolognani <address@hidden>
Signed-off-by: David Gibson <address@hidden>
  target-ppc/cpu-models.c | 4 +++-
  target-ppc/cpu-models.h | 1 +
  2 files changed, 4 insertions(+), 1 deletion(-)


Not sure if this counts as a bugfix which can be merged now we're in
the hard freeze.  The lack of it does mean we can't work on one of our
dev machines which has this CPU.

Why is this a stopper? We stopped bothering with exact PVRs some time ago
and -cpu POWER8 or -cpu host still work.

Andrea, can you clarify?

I think it's because libvirt likes to specify a specific CPU - and if
it gets the new PVR from the host, qemu won't understand it.

A specific CPU in this case is "POWER8", I added this specifically for libvirt (to allow migration between all versions of POWER8), it should not use versioned CPUs and it does not in powerkvm.

There is actually a patch to make this PVR masking/subclassing nicer, I replied to it with adding you in cc:, please have a look. Andreas Faerber had objections which I did not really grasp then.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]