[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 11/28] Fail more cleanly in mismatched RAM cases

From: Juan Quintela
Subject: [Qemu-devel] [PULL 11/28] Fail more cleanly in mismatched RAM cases
Date: Tue, 7 Jul 2015 15:08:52 +0200

From: "Dr. David Alan Gilbert" <address@hidden>

If the number of RAMBlocks was different on the source from the
destination, QEMU would hang waiting for a disconnect on the source
and wouldn't release from that hang until the destination was manually

Mark the stream as being in error, this causes the destination to die
and the source to carry on.

(It still gets a whole bunch of warnings on the destination, and I've
not managed to complete another migration after the 1st one, still

Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Juan Quintela <address@hidden>
 migration/rdma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/migration/rdma.c b/migration/rdma.c
index 73a79be..f106b2a 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -3328,6 +3328,7 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void 
                         "Your QEMU command line parameters are probably "
                         "not identical on both the source and destination.",
                         local->nb_blocks, nb_dest_blocks);
+            rdma->error_state = -EINVAL;
             return -EINVAL;

@@ -3343,6 +3344,7 @@ static int qemu_rdma_registration_stop(QEMUFile *f, void 
                             "vs %" PRIu64, local->block[i].block_name, i,
+                rdma->error_state = -EINVAL;
                 return -EINVAL;
             local->block[i].remote_host_addr =

reply via email to

[Prev in Thread] Current Thread [Next in Thread]