qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done
Date: Tue, 7 Jul 2015 11:22:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1


On 07/07/2015 11:07, Eric Auger wrote:
> On 07/07/2015 11:02 AM, Paolo Bonzini wrote:
>>
>>
>> On 07/07/2015 11:00, Eric Auger wrote:
>>> Hi Paolo, Peter,
>>> On 06/22/2015 11:58 AM, Eric Auger wrote:
>>>> On 06/22/2015 11:53 AM, Paolo Bonzini wrote:
>>>>>
>>>>>
>>>>> On 22/06/2015 11:49, Eric Auger wrote:
>>>>>>>> It seems safe because rom_load_all really doesn't load anything, it 
>>>>>>>> only
>>>>>>>> does an overlap check.  Is this right?
>>>>>> it does the check + isrom field setting
>>>>>>>>
>>>>>>>> Is the bug that some overlapping ROMs are not detected?  The commit
>>>>>>>> message is not clear.
>>>>>> The regression is that the both overlap check and isrom setting are not
>>>>>> done since ROM are inserted in the roms list afterwards, at machine init
>>>>>> done time. The bug was not really observed yet I think.
>>>>>
>>>>> isrom is just an optimization though, right?  What is it useful for?
>>>> My understanding is it serves 2 purposes:
>>>>
>>>> - report info in the monitor (hmp_info_roms)
>>>> - decide whether the rom->data can be freed on ROM reset notifier
>>>> (rom_reset).
>>>>
>>>> Hope I didn't miss anything else.
>>>>
>>>> Eric
>>>
>>> What do we decide then about this regression on arm. Do we fix it in 2.4
>>> or later?
>>
>> Yes, it should be fixed in 2.4.
> Do you want me to resend it with a new commit message or is the context
> clearer now?

It's okay, thanks!

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]