[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 01/11] vfio: fix return type of pread

From: Alex Williamson
Subject: [Qemu-devel] [PULL 01/11] vfio: fix return type of pread
Date: Mon, 06 Jul 2015 12:34:43 -0600
User-agent: StGit/0.17.1-dirty

From: Paolo Bonzini <address@hidden>

size_t is an unsigned type, thus the error case is never reached in
the below call to pread.  If bytes is negative, it will be seen as
a very high positive value.

Spotted by Coverity.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>
 hw/vfio/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e0e339a..b8fa4ac 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -939,7 +939,7 @@ static void vfio_pci_load_rom(VFIOPCIDevice *vdev)
     uint64_t size;
     off_t off = 0;
-    size_t bytes;
+    ssize_t bytes;
     if (ioctl(vdev->vbasedev.fd, VFIO_DEVICE_GET_REGION_INFO, &reg_info)) {
         error_report("vfio: Error getting ROM info: %m");

reply via email to

[Prev in Thread] Current Thread [Next in Thread]