Re: [Qemu-devel] [PULL 18/19] Stop including qemu-common.h in memory.h

[Peter Maydell]

On 6 July 2015 at 13:35, Paolo Bonzini <address@hidden> wrote:
> From: Peter Maydell <address@hidden>
> --- /dev/null
> +++ b/include/qemu/fprintf-fn.h
> @@ -0,0 +1,16 @@
> +/*
> + * Typedef for fprintf-alike function pointers.
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#ifndef FPRINTF_FN_H

Whoops. There should be a
#define FPRINTF_FN_H

here... (gcc doesn't complain about the redefinition of the typedef,
but clang does.)

> +
> +#include "qemu/compiler.h"
> +#include <stdio.h>
> +
> +typedef int (*fprintf_function)(FILE *f, const char *fmt, ...)
> +    GCC_FMT_ATTR(2, 3);
> +
> +#endif

thanks & apologies
-- PMM