qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for se


From: Pavel Dovgaluk
Subject: Re: [Qemu-devel] [PATCH v5 08/11] target-i386: exception handling for seg_helper functions
Date: Mon, 6 Jul 2015 15:15:42 +0300

> From: Richard Henderson [mailto:address@hidden On Behalf Of Richard Henderson
> On 07/06/2015 09:26 AM, Pavel Dovgalyuk wrote:
> > This patch fixes exception handling for seg_helper functions.
> >
> > Signed-off-by: Pavel Dovgalyuk <address@hidden>
> 
> 
> No, you don't want to discriminately change every call.  That was my original
> point about not needing to change seg_helper.c or smm_helper.c.
> 
> Further, any such changes would go along with the changes in translate.c to
> remove the state saving there.
> 
> I would only change those that are "normal" memory operations, like fp loads
> etc.  The segmentation changes are rare.  The task state helpers require state
> saving anyway, so requiring a TCG search is a pessimization.

Then we'll have to stop the translation after every instruction that uses these 
function.
Is this a limited subset?

Pavel Dovgalyuk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]