[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz
From: |
Antony Pavlov |
Subject: |
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz. |
Date: |
Mon, 6 Jul 2015 10:33:04 +0300 |
On Sun, 5 Jul 2015 21:18:11 -0700
Serge Vakulenko <address@hidden> wrote:
> On Wed, Jul 1, 2015 at 6:41 AM, Aurelien Jarno <address@hidden> wrote:
> > On 2015-06-30 21:12, Serge Vakulenko wrote:
> >> Signed-off-by: Serge Vakulenko <address@hidden>
> >> ---
> >> hw/mips/Makefile.objs | 3 +
> >> hw/mips/mips_pic32mx7.c | 1652 +++++++++++++++++++++++++
> >> hw/mips/mips_pic32mz.c | 2840
> >> +++++++++++++++++++++++++++++++++++++++++++
> >> hw/mips/pic32_ethernet.c | 557 +++++++++
> >> hw/mips/pic32_gpio.c | 39 +
> >> hw/mips/pic32_load_hex.c | 238 ++++
> >> hw/mips/pic32_peripherals.h | 210 ++++
> >> hw/mips/pic32_sdcard.c | 428 +++++++
> >> hw/mips/pic32_spi.c | 121 ++
> >> hw/mips/pic32_uart.c | 228 ++++
> >> hw/mips/pic32mx.h | 1290 ++++++++++++++++++++
> >> hw/mips/pic32mz.h | 2093 +++++++++++++++++++++++++++++++
> >> 12 files changed, 9699 insertions(+)
> >> create mode 100644 hw/mips/mips_pic32mx7.c
> >> create mode 100644 hw/mips/mips_pic32mz.c
> >> create mode 100644 hw/mips/pic32_ethernet.c
> >> create mode 100644 hw/mips/pic32_gpio.c
> >> create mode 100644 hw/mips/pic32_load_hex.c
> >> create mode 100644 hw/mips/pic32_peripherals.h
> >> create mode 100644 hw/mips/pic32_sdcard.c
> >> create mode 100644 hw/mips/pic32_spi.c
> >> create mode 100644 hw/mips/pic32_uart.c
> >> create mode 100644 hw/mips/pic32mx.h
> >> create mode 100644 hw/mips/pic32mz.h
> >
> > This patch is huge, and needs to be splitted to ease the review.
>
> I'll prepare a new patch set, with every new file put into a separate
> message. Other issues fixed as well.
Putting every new file into a separate message is a nonsense.
Please separate __logical changes__ into a single patch.
--
Best regards,
Antony Pavlov
- Re: [Qemu-devel] [PATCH pic32 v2 3/5] Added support for external interrupt controller (EIC) mode., (continued)
Message not available
- [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/01
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Aurelien Jarno, 2015/07/01
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/06
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz.,
Antony Pavlov <=
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/06
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Peter Crosthwaite, 2015/07/06
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/07
- Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Aurelien Jarno, 2015/07/07
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/02
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Serge Vakulenko, 2015/07/06
Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz., Antony Pavlov, 2015/07/06
Re: [Qemu-devel] [PATCH pic32 v2 0/5] Support for Microchip pic32mx7 and pic32mz microcontrollers, Antony Pavlov, 2015/07/02