[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: update bdrv_drain_all()/bdrv_drain() com

From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH] block: update bdrv_drain_all()/bdrv_drain() comments
Date: Mon, 6 Jul 2015 11:41:11 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, 07/02 17:24, Stefan Hajnoczi wrote:
> The doc comments for bdrv_drain_all() and bdrv_drain() are outdated:
>  * The bdrv_drain() comment is a poor man's bdrv_lock()/bdrv_unlock()
>    which Fam Zheng is currently developing.  Unfortunately this warning
>    was never really enough because devices keep submitting I/O and op
>    blockers don't prevent that.
>  * The bdrv_drain_all() comment is still partially correct but reflects
>    the nature of the implementation rather than API documentation.
> Do make it clear that bdrv_drain() is only appropriate within an
> AioContext.  For anything spanning AioContexts you need
> bdrv_drain_all().
> Cc: Markus Armbruster <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>

Reviewed-by: Fam Zheng <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]