[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 00/16] Add an IPMI device to QEMU |
Date: |
Fri, 3 Jul 2015 08:50:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 |
On 09/06/2015 03:11, address@hidden wrote:
> I have reworked the QEMU IPMI patches, and I believe this design
> improves greatly on the previous one. The suggestions made all
> resulted in better design. To start an IPMI interface
> with this, you would use:
>
> -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0
>
> Note that I did not make the BMCs objects. I started this way, but
> adding properties was ending up duplicating a lot of code already
> in the device core, especially for the chardev link.
>
> I'm not sure of the importance of having a BMC be an object instead
> of a device, but it seems to me that if we do that, it would be
> best to add helper functions to the object core for the chardev
> and integer properties.
Hi, sorry for the delay. I missed this because I left for vacation
exactly on the day it was posted. I think it's okay to have it as a device.
Michael, are you going to merge it? Otherwise, just ack the patches and
I will take care of it. Time is ticking fast...
Paolo