[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface |
Date: |
Thu, 02 Jul 2015 18:47:03 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
Am 02.07.2015 um 18:36 schrieb Jason J. Herne:
> Provide a method to throttle guest cpu execution. CPUState is augmented with
> timeout controls and throttle start/stop functions. To throttle the guest cpu
> the caller simply has to call the throttle set function and provide a
> percentage
> of throttle time.
>
> Signed-off-by: Jason J. Herne <address@hidden>
> Reviewed-by: Matthew Rosato <address@hidden>
> ---
> cpus.c | 66
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> include/qom/cpu.h | 38 ++++++++++++++++++++++++++++++++
> 2 files changed, 104 insertions(+)
No objections from my side, but the interesting code is outside my area.
I feel we (including myself) are abusing include/qom/cpu.h (here there's
not even a single CPUState argument) but I don't have a better
suggestion. At some point we'll need to revisit the cpu.h vs. cpu-all.h
etc. split or even introduce something new.
I'm preparing a qom-cpu pull and assume this will go through the
migration tree when finalized.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, (continued)
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/07/13
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Paolo Bonzini, 2015/07/13
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/07/15
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Paolo Bonzini, 2015/07/15
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/07/16
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Paolo Bonzini, 2015/07/23
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/07/31
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Paolo Bonzini, 2015/07/31
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/07/31
- Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/07/31
Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface,
Andreas Färber <=
[Qemu-devel] [PATCH v4 3/5] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/07/02
[Qemu-devel] [PATCH v4 4/5] qmp/hmp: Add throttle ratio to query-migrate and info migrate, Jason J. Herne, 2015/07/02
[Qemu-devel] [PATCH v4 2/5] migration: Parameters for auto-converge cpu throttling, Jason J. Herne, 2015/07/02
[Qemu-devel] [PATCH v4 0/5] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/07/02