qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 00/16] implement vNVDIMM
Date: Thu, 2 Jul 2015 11:52:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1


On 02/07/2015 11:20, Stefan Hajnoczi wrote:
> > Currently, the NVDIMM driver has been merged into upstream Linux Kernel and
> > this patchset tries to enable it in virtualization field
> 
> From a device model perspective, have you checked whether it makes sense
> to integrate nvdimms into the pc-dimm and hostmem code that is used for
> memory hotplug and NUMA?
> 
> The NVDIMM device in your patches is a completely new TYPE_DEVICE so it
> doesn't share any interfaces or code with existing memory devices.
> Maybe that is the right solution here because NVDIMMs have different
> characteristics, but I'm not sure.

The hostmem code should definitely be shared, e.g. by adding a new
"file" property to the memory-backend-file class.  ivshmem can also use
it---CCing Marc-André.

I don't know about the pc-dimm devices.  If the NVDIMM devices can do
_OST and can be hotplugged, then the answer is probably yes.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]