[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 11/17] block: Remove bdrv_reset_dirty
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 11/17] block: Remove bdrv_reset_dirty |
Date: |
Thu, 2 Jul 2015 10:19:43 +0100 |
From: Fam Zheng <address@hidden>
Using this function would always be wrong because a dirty bitmap must
have a specific owner that consumes the dirty bits and calls
bdrv_reset_dirty_bitmap().
Remove the unused function to avoid future misuse.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
block.c | 12 ------------
include/block/block_int.h | 2 --
2 files changed, 14 deletions(-)
diff --git a/block.c b/block.c
index 81233be..7e130cc 100644
--- a/block.c
+++ b/block.c
@@ -3528,18 +3528,6 @@ void bdrv_set_dirty(BlockDriverState *bs, int64_t
cur_sector,
}
}
-void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,
- int nr_sectors)
-{
- BdrvDirtyBitmap *bitmap;
- QLIST_FOREACH(bitmap, &bs->dirty_bitmaps, list) {
- if (!bdrv_dirty_bitmap_enabled(bitmap)) {
- continue;
- }
- hbitmap_reset(bitmap->bitmap, cur_sector, nr_sectors);
- }
-}
-
/**
* Advance an HBitmapIter to an arbitrary offset.
*/
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 83ed1a5..8996baf 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -662,7 +662,5 @@ bool blk_dev_is_medium_locked(BlockBackend *blk);
void blk_dev_resize_cb(BlockBackend *blk);
void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, int nr_sectors);
-void bdrv_reset_dirty(BlockDriverState *bs, int64_t cur_sector,
- int nr_sectors);
#endif /* BLOCK_INT_H */
--
2.4.3
- [Qemu-devel] [PULL 01/17] block/iscsi: add support for request timeouts, (continued)
- [Qemu-devel] [PULL 01/17] block/iscsi: add support for request timeouts, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 02/17] qcow2: Handle EAGAIN returned from update_refcount, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 03/17] qapi: Rename 'dirty-bitmap' mode to 'incremental', Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 04/17] blockdev: no need to drain+flush in hmp_drive_del, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 05/17] timer: Move NANOSECONDS_PER_SECONDS to timer.h, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 06/17] timer: Use a single definition of NSEC_PER_SEC for the whole codebase, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 07/17] block: Add bdrv_get_block_status_above, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 08/17] qmp: Add optional bool "unmap" to drive-mirror, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 09/17] mirror: Do zero write on target if sectors not allocated, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 10/17] block: Fix dirty bitmap in bdrv_co_discard, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 11/17] block: Remove bdrv_reset_dirty,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 12/17] qemu-iotests: Make block job methods common, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 13/17] qemu-iotests: Add test case for mirror with unmap, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 14/17] iotests: Use event_wait in wait_ready, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 15/17] block/iscsi: restore compatiblity with libiscsi 1.9.0, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 16/17] block/nfs: limit maximum readahead size to 1MB, Stefan Hajnoczi, 2015/07/02
- [Qemu-devel] [PULL 17/17] block: remove redundant check before g_slist_find(), Stefan Hajnoczi, 2015/07/02
- Re: [Qemu-devel] [PULL 00/17] Block patches, Peter Maydell, 2015/07/02
- Re: [Qemu-devel] [PULL 00/17] Block patches, Peter Maydell, 2015/07/07