Re: [Qemu-devel] [RFC PATCH V6 03/18] remove unused spinlock.

[Frederic Konrad]

On 26/06/2015 16:53, Paolo Bonzini wrote:
> On 26/06/2015 16:47, address@hidden wrote:
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 7f0aae9..d1e482a 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2664,11 +2664,6 @@ sub process {
> >                         WARN("Use of volatile is usually wrong: see 
> > Documentation/volatile-considered-harmful.txt\n" . $herecurr);
> >                 }
> >   
> > -# SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
> > -               if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
> > -                       ERROR("Use of $1 is deprecated: see 
> > Documentation/spinlocks.txt\n" . $herecurr);
> > -               }
> > -
> >   # warn about #if 0
> >                 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
> >                         CHK("if this code is redundant consider removing it\n" .
> > @@ -2717,8 +2712,8 @@ sub process {
> >                         ERROR("exactly one space required after that #$1\n" . 
> > $herecurr);
> >                 }
> >   
> > -# check for spinlock_t definitions without a comment.
> > -               if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
> > +# check for mutex definitions without a comment.
> > +               if ($line =~ /^.\s*(struct\s+mutex)\s+\S+;/ ||
> >                     $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
> >                         my $which = $1;
> >                         if (!ctx_has_comment($first_line, $linenr)) {
> The checkpatch.pl parts simply come from Linux.  They don't matter for
> QEMU, but we're limiting the changes to the minimum in this script.
>
> Paolo
Ok so I can drop this part from the patch?

Thanks,
Fred