qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper
Date: Wed, 24 Jun 2015 11:01:30 +0100

On 24 June 2015 at 03:50, Peter Crosthwaite
<address@hidden> wrote:
> On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber <address@hidden> wrote:
>> I believe this argument will probably go away; otherwise this should've
>> been &error_abort or something instead of NULL.
>>
>
> I'm not sure. As I don't see what is catching the case of a gdb 'c'
> packet for a CPU that doesn't implement set_pc. I'd rather preserve
> the existing behaviour, and have the qom wrapper do nothing if it is
> not implemented.

Well, this is one reason why every CPU needs to implement set_pc...

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]