|
From: | Markus Armbruster |
Subject: | Re: [Qemu-devel] [PULL v2 58/60] qdev: add 64bit properties |
Date: | Tue, 23 Jun 2015 08:55:16 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Gonglei <address@hidden> writes: > On 2015/6/21 5:10, Paolo Bonzini wrote: >> >> >> On 01/06/2015 14:25, Michael S. Tsirkin wrote: >>> +static uint64_t qdev_get_prop_mask64(Property *prop) >>> +{ >>> + assert(prop->info == &qdev_prop_bit); >>> + return 0x1 << prop->bitnr; >> >> This needs to be 1ull. >> > Yes, and coverity spot it and some other OVERRUN problems. Patch author(s) know? Or are you taking care of them?
[Prev in Thread] | Current Thread | [Next in Thread] |