[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Peek dont read for vmdescription
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] [PATCH] Peek dont read for vmdescription |
|
Date: |
Tue, 23 Jun 2015 00:18:15 +0200 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 22.06.15 16:49, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> The VMDescription section maybe after the EOF mark, the current code
> does a 'qemu_get_byte' and either gets the header byte identifying the
> description or an error (which it ignores). Doing the 'get' upsets
> RDMA which hangs on old machine types without the VMDescription.
>
> Using 'qemu_peek_byte' avoids that.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Fun. I did actually use peek at first and then figured it's the same as
read in the qemu file implementation. Have you figured out why exactly
peek does make a difference for the RDMA case?
Alex