Re: [Qemu-devel] [PATCH] vl: move rom_load_all after machine init done

[Eric Auger]

Hi Paolo,
On 06/22/2015 11:43 AM, Paolo Bonzini wrote:
> 
> 
> On 22/06/2015 11:26, Eric Auger wrote:
>> ping
>>
>> Do you think that change is sensible? Since this takes place in vl.c I
>> am quite scared but with your experience you may know how much this can
>> be wrong.
> 
> It seems safe because rom_load_all really doesn't load anything, it only
> does an overlap check.  Is this right?
it does the check + isrom field setting
> 
> Is the bug that some overlapping ROMs are not detected?  The commit
> message is not clear.
The regression is that the both overlap check and isrom setting are not
done since ROM are inserted in the roms list afterwards, at machine init
done time. The bug was not really observed yet I think.

Best Regards

Eric
> 
> Paolo
>