[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 11/16] libqos/ahci: edit wait to be ncq aware
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH 11/16] libqos/ahci: edit wait to be ncq aware |
Date: |
Fri, 19 Jun 2015 21:50:42 -0400 |
The wait command should check to make sure SACT is clear as well
as the Command Issue register.
Signed-off-by: John Snow <address@hidden>
---
tests/libqos/ahci.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index 9a4d510..da02e2e 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -908,11 +908,15 @@ void ahci_command_wait(AHCIQState *ahci, AHCICommand *cmd)
/* We can't rely on STS_BSY until the command has started processing.
* Therefore, we also use the Command Issue bit as indication of
* a command in-flight. */
- while (BITSET(ahci_px_rreg(ahci, cmd->port, AHCI_PX_TFD),
- AHCI_PX_TFD_STS_BSY) ||
- BITSET(ahci_px_rreg(ahci, cmd->port, AHCI_PX_CI), (1 <<
cmd->slot))) {
+
+#define RSET(REG, MASK) (BITSET(ahci_px_rreg(ahci, cmd->port, (REG)), (MASK)))
+
+ while (RSET(AHCI_PX_TFD, AHCI_PX_TFD_STS_BSY) ||
+ RSET(AHCI_PX_CI, 1 << cmd->slot) ||
+ (cmd->props->ncq && RSET(AHCI_PX_SACT, 1 << cmd->slot))) {
usleep(50);
}
+
}
void ahci_command_issue(AHCIQState *ahci, AHCICommand *cmd)
--
2.1.0
- Re: [Qemu-devel] [PATCH 04/16] ahci: check for ncq prdtl overflow, (continued)
- [Qemu-devel] [PATCH 02/16] ahci: use shorter variables, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 05/16] ahci: separate prdtl from opts, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 08/16] ahci: clear error register before NCQ cmd, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 07/16] ahci: ncq sector count correction, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 09/16] libqos/ahci: fix cmd_sanity for ncq, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 10/16] libqos/ahci: add NCQ frame support, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 11/16] libqos/ahci: edit wait to be ncq aware,
John Snow <=
- [Qemu-devel] [PATCH 12/16] libqos/ahci: adjust expected NCQ interrupts, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 13/16] libqos/ahci: set the NCQ tag on command_commit, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 14/16] libqos/ahci: Force all NCQ commands to be LBA48, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 16/16] qtest/ahci: ncq migration test, John Snow, 2015/06/19
- [Qemu-devel] [PATCH 15/16] qtest/ahci: simple ncq data test, John Snow, 2015/06/19
- Re: [Qemu-devel] [PATCH 00/16] ahci: ncq cleanup, part 1, Stefan Hajnoczi, 2015/06/22