[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse "backing_refer
From: |
Wen Congyang |
Subject: |
Re: [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse "backing_reference" option to reference existing BDS |
Date: |
Thu, 18 Jun 2015 19:40:16 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/18/2015 06:50 PM, Stefan Hajnoczi wrote:
> On Thu, Jun 18, 2015 at 04:49:09PM +0800, Wen Congyang wrote:
>> Usage:
>> -drive file=xxx,id=Y, \
>> -drive
>> file=xxxx,id=X,backing_reference.drive_id=Y,backing_reference.hidden-disk.*
>>
>> It will create such backing chain:
>> {virtio-blk dev 'Y'}
>> {virtio-blk dev 'X'}
>> |
>> |
>> |
>> |
>> v
>> v
>>
>> [base] <- [mid] <- ( Y ) <----------------- (hidden target)
>> <--------------- ( X )
>>
>> v ^
>> v ^
>> v ^
>> v ^
>> >>>> drive-backup sync=none >>>>
>>
>> X's backing file is hidden-disk, and hidden-disk's backing file is Y.
>> Disk Y may be opened or reopened in read-write mode, so A block backup
>> job is automatically created: source is Y and target is hidden disk.
>> Active disk X, hidden disk, and Y are all on the same AioContext.
>
> The command-line option name confused me. I expected "backing_reference" to
> result in:
>
> Y <- X
So if I want to create
Y <- hidden-disk <- X
The command line can be
backing.file.filename=xxx,backing.driver=xxx,backing.backing.backing_reference=Y
>
> The backup block job and hidden target makes this option more than just
> referencing the backing device.
>
> The name "backing.backup-reference" is clearer to me, but I think Kevin
> might have more idea for you on this patch.
>
Any suggestion is welcome.
Thanks
Wen Congyang
- [Qemu-devel] [PATCH COLO-Block v6 03/16] Allow creating backup jobs when opening BDS, (continued)
- [Qemu-devel] [PATCH COLO-Block v6 03/16] Allow creating backup jobs when opening BDS, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 02/16] allow writing to the backing file, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 05/16] Backup: clear all bitmap when doing block checkpoint, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 06/16] Don't allow a disk use backing reference target, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 07/16] Add new block driver interface to connect/disconnect the remote target, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 04/16] block: Parse "backing_reference" option to reference existing BDS, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 09/16] Introduce a new -drive option to control whether to connect to remote target, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 08/16] NBD client: implement block driver interfaces to connect/disconnect NBD server, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 10/16] NBD client: connect to nbd server later, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 12/16] skip nbd_target when starting block replication, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 11/16] Add new block driver interfaces to control block replication, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 14/16] introduce a new API qemu_opts_absorb_qdict_by_index(), Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 13/16] quorum: implement block driver interfaces for block replication, Wen Congyang, 2015/06/18
- [Qemu-devel] [PATCH COLO-Block v6 15/16] quorum: allow ignoring child errors, Wen Congyang, 2015/06/18