Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

[Michael S. Tsirkin]

On Wed, Jun 17, 2015 at 09:24:44PM +0200, Paolo Bonzini wrote:
> 
> 
> On 17/06/2015 21:22, Michael S. Tsirkin wrote:
> > > Does it make sense to have an ISA device that has no ports or MMIO
> > > regions?  It's a bit of hack modeling-wise, but sure it works.
> > 
> > I didn't write this code :)
> 
> Well, you did: :)

I merely copied a snippet from Don's patches.

> >>> +        vmport_rpc = isa_try_create(isa_bus, "vmport_rpc");
> >>> +        if (vmport_rpc) {
> >>> +            qdev_init_nofail(DEVICE(vmport_rpc));
> >>> +        }
> 
> vmport does have a port.  vmport_rpc doesn't, it would use the same port
> as the main vmport device (which would dispatch to vmport_rpc).
> 
> Paolo

Right but that's how Don chose to model it anyway.

-- 
MST