Re: [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP command handlers

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 06/13/2015 08:20 AM, Markus Armbruster wrote:
>> qerror_report() is a transitional interface to help with converting
>> existing monitor commands to QMP.  It should not be used elsewhere.
>> Replace by error_report() in initial startup helpers parse_sandbox()
>> and parse_add_fd().
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  vl.c | 23 +++++++++--------------
>>  1 file changed, 9 insertions(+), 14 deletions(-)
>> 
>
>>  #else
>> -        qerror_report(ERROR_CLASS_GENERIC_ERROR,
>> -                      "sandboxing request but seccomp is not compiled into 
>> this build");
>> +        error_report("sandboxing request but seccomp is not compiled "
>> +                     "into this build");
>
> Pre-existing, but s/request/requested/ would sound better while touching
> this.

The full error message is

    qemu-kvm-x86_64: -sandbox on: sandboxing request but seccomp is not 
compiled into this build

I think

    qemu-kvm-x86_64: -sandbox on: seccomp is not compiled into this build

would do just fine.

I guess I'd happily squash that into a shorter patch, but this one is
big enough for me to prefer a separate patch.

> Either way,
> Reviewed-by: Eric Blake <address@hidden>

Thanks!