Re: [Qemu-devel] [PATCH 07/16] qapi: Simplify inclusion cycle detection

[Eric Blake]

On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> We maintain a stack of filenames in include_hist for convenient cycle
> detection.
> 
> As error_path() demonstrates, the same information is readily
> available in the expr_info, so just use that, and drop include_hist.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py | 18 ++++++++----------
>  1 file changed, 8 insertions(+), 10 deletions(-)
> 

Yet another parameter gone, and the testsuite proves we don't regress in
error message quality.  I'm glad I spent time on the testsuite!

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature