Re: [Qemu-devel] [PULL 0/9] Error reporting patches

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 8 June 2015 at 19:02, Markus Armbruster <address@hidden> wrote:
>> The following changes since commit ee09f84e6bf5383a23c9624115c26b72aa1e076c:
>>
>>   Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream'
>> into staging (2015-06-08 15:57:41 +0100)
>>
>> are available in the git repository at:
>>
>>
>>   git://repo.or.cz/qemu/armbru.git tags/pull-error-2015-06-08
>>
>> for you to fetch changes up to c2d8c8078cc10065c0a96dad94b0cf4bd5db9856:
>>
>>   vhost-user: Improve -netdev/netdev_add/-net/... error reporting
>> (2015-06-08 19:33:21 +0200)
>>
>> ----------------------------------------------------------------
>> Error reporting patches
>>
>> ----------------------------------------------------------------
>
> Hi. I'm afraid this doesn't build for win32:
>
> /home/petmay01/linaro/qemu-for-merges/vl.c: In function ‘main’:
> /home/petmay01/linaro/qemu-for-merges/vl.c:3813: error: ‘parse_add_fd’
> undeclared (first use in this function)
> /home/petmay01/linaro/qemu-for-merges/vl.c:3813: error: (Each
> undeclared identifier is reported only once
> /home/petmay01/linaro/qemu-for-merges/vl.c:3813: error: for each
> function it appears in.)
> /home/petmay01/linaro/qemu-for-merges/vl.c:3818: error:
> ‘cleanup_add_fd’ undeclared (first use in this function)
> make: *** [vl.o] Error 1
>
> Definition of function guarded with #ifndef _WIN32
> but use guarded with #ifndef _win32 -- you want
> the all-uppercase one.
>
> thanks
> -- PMM

Uh, no idea how that line got messed up.  Respin on the way!