Re: [Qemu-devel] [PATCH v2 15/23] target-i386: use memory API to implement SMRAM

[Peter Crosthwaite]

On Wed, Jun 3, 2015 at 10:08 AM, Paolo Bonzini <address@hidden> wrote:
> Remove cpu_smm_register and cpu_smm_update.  Instead, each CPU
> address space gets an extra region which is an alias of
> /machine/smram.  This extra region is enabled or disabled
> as the CPU enters/exits SMM.
>

Why is the connectivity from machine->CPU made via a predetermined
canon path? This has come up for me a few times out-of-tree and I have
managed it via links. Can the machine create the smram bus as a
MemoryRegion and in a loop pass it to each CPU via a MemoryRegion *
link?

Regards,
Peter

> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  bsd-user/main.c           |  4 ----
>  hw/i386/pc.c              | 21 ---------------------
>  hw/pci-host/pam.c         | 18 ++----------------
>  hw/pci-host/piix.c        | 28 ++++++++--------------------
>  hw/pci-host/q35.c         | 22 ++++++----------------
>  include/hw/i386/pc.h      |  1 -
>  include/hw/pci-host/pam.h |  5 +----
>  include/hw/pci-host/q35.h |  1 -
>  linux-user/main.c         |  4 ----
>  target-i386/cpu-qom.h     |  4 +++-
>  target-i386/cpu.c         | 33 +++++++++++++++++++++++++++++++--
>  target-i386/cpu.h         |  3 ++-
>  target-i386/machine.c     |  3 +++
>  target-i386/smm_helper.c  | 14 ++++++++++++--
>  14 files changed, 68 insertions(+), 93 deletions(-)
>