[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] migration: Dynamic cpu throttling for au
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] migration: Dynamic cpu throttling for auto-converge |
Date: |
Tue, 02 Jun 2015 14:08:05 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 06/02/2015 11:46 AM, Jason J. Herne wrote:
> Remove traditional auto-converge static 30ms throttling code and replace it
> with a dynamic throttling algorithm.
>
> Additionally, be more aggressive when deciding when to start throttling.
> Previously we waited until four unproductive memory passes. Now we begin
> throttling after only two unproductive memory passes. Four seemed quite
> arbitrary and only waiting for two passes allows us to complete the migration
> faster.
>
> Signed-off-by: Jason J. Herne <address@hidden>
> Reviewed-by: Matthew Rosato <address@hidden>
> ---
> arch_init.c | 95
> +++++++++++++++++----------------------------------
> migration/migration.c | 9 +++++
> 2 files changed, 41 insertions(+), 63 deletions(-)
>
> +static void mig_throttle_guest_down(void)
> +{
> + CPUState *cpu;
> +
> + CPU_FOREACH(cpu) {
> + /* We have not started throttling yet. Lets start it.*/
s/Lets/Let's/
s|it.*/|it. */|
> + if (!cpu_throttle_active(cpu)) {
> + cpu_throttle_start(cpu, 0.2);
> + }
> +
> + /* Throttling is already in place. Just increase the throttling rate
> */
> + else {
Unusual layout. More typical would be:
if (...) {
...
} else {
/* comment */
...
}
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/3] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/06/02
- [Qemu-devel] [PATCH v2 2/3] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/06/02
- Re: [Qemu-devel] [PATCH v2 2/3] migration: Dynamic cpu throttling for auto-converge,
Eric Blake <=
- [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/06/02
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Juan Quintela, 2015/06/03
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/06/03
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Dr. David Alan Gilbert, 2015/06/03
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/06/03
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/06/08
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Dr. David Alan Gilbert, 2015/06/09
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/06/09
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Dr. David Alan Gilbert, 2015/06/10
- Re: [Qemu-devel] [PATCH v2 1/3] cpu: Provide vcpu throttling interface, Jason J. Herne, 2015/06/10