qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"


From: Andrey Korolyov
Subject: Re: [Qemu-devel] [PATCH v6 01/13] block: Add op blocker type "device IO"
Date: Fri, 29 May 2015 14:11:55 +0300

On Thu, May 28, 2015 at 3:05 PM, Fam Zheng <address@hidden> wrote:
> On Thu, 05/28 13:19, Paolo Bonzini wrote:
>>
>>
>> On 28/05/2015 13:11, Fam Zheng wrote:
>> > > Whoever uses ioeventfd needs to implement pause/resume, yes---not just
>> > > dataplane, also "regular" virtio-blk/virtio-scsi.
>> > >
>> > > However, everyone else should be okay, because the bottom half runs
>> > > immediately and the big QEMU lock is not released in the meanwhile.  So
>> > > the CPUs have no occasion to run.  This needs a comment!
>> >
>> > I'm not sure. It seems timer callbacks also do I/O, for example
>> > nvme_process_sq().
>>
>> Right, that's also true for USB devices. :(
>>
>> Perhaps we can skip block_job_defer_to_main_loop if not necessary
>> (bs->aio_context == qemu_get_aio_context()).
>
> I think so. It will make dataplane even more specialized but that seems the
> only way to fix the problem at the moment.
>
> Fam
>

Sorry for a potential thread hijack, but I`m curious about the reasons
to not making advertised queue depth for non-passthrough backends an
independent tunable, is there any concerns behind that?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]