[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object |
Date: |
Thu, 28 May 2015 08:52:46 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/28/2015 06:21 AM, Markus Armbruster wrote:
> Failure to create a -object is a fatal error. However, we delay the
s/a -object/an -object/ ? (depends on whether you pronounce '-object' as
"object" or "dash-object")
> actual exit until all -object are processed. On the one hand, this
> permits detection of genuine additional errors. On the other hand, it
> can muddy the waters with uninteresting additional errors, e.g. when a
> later -object tries to reference a prior one that failed.
>
> We generally stop right on the first bad option, so do that for
> -object as well.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 1/9] vl: Report failure to sandbox at most once, (continued)
- [Qemu-devel] [PATCH 9/9] vhost-user: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2015/05/28
- [Qemu-devel] [PATCH 2/9] vl: Print -device help at most once, Markus Armbruster, 2015/05/28
- [Qemu-devel] [PATCH 7/9] QemuOpts: Drop qemu_opt_foreach() parameter abort_on_failure, Markus Armbruster, 2015/05/28
- [Qemu-devel] [PATCH 8/9] QemuOpts: Convert qemu_opt_foreach() to Error, Markus Armbruster, 2015/05/28
- [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object, Markus Armbruster, 2015/05/28
- Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object,
Eric Blake <=
- [Qemu-devel] [PATCH 4/9] QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure, Markus Armbruster, 2015/05/28
- [Qemu-devel] [PATCH 5/9] QemuOpts: Convert qemu_opts_foreach() to Error, Markus Armbruster, 2015/05/28
- [Qemu-devel] [PATCH 6/9] blkdebug: Simplify passing of Error through qemu_opts_foreach(), Markus Armbruster, 2015/05/28
- Re: [Qemu-devel] [PATCH 0/9] Miscellaneous error reporting improvements, Kevin Wolf, 2015/05/29