[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/2] monitor: suggest running "help" for command
From: |
Bandan Das |
Subject: |
[Qemu-devel] [PATCH v3 0/2] monitor: suggest running "help" for command errors |
Date: |
Wed, 27 May 2015 19:19:12 -0400 |
Hi Markus,
It seems we can directly use cmdline to track current location
when parsing. It's not being reused anywhere else and my unit
tests didn't show any problems. Am I missing something ?
Once everything looks ok, I can rebase this on top of your
patches. Thanks for taking the time to review this!
Bandan
v3:
Track the current location directly in the command line [1/2]
Fix potential qdict leak [1/2]
Document char **endp [1/2]
Rebase on top of changes and add reviewed-by [2/2]
v2:
Split up the command name and arguments parsing into
separate functions. [1/2]
Skip checking for failures with commands that use the .cmd_new
interface or the async interface since they are scheduled
for removal [2/2]
Bandan Das (2):
monitor: cleanup parsing of cmd name and cmd arguments
When a command fails due to incorrect syntax or input, suggest
using the "help" command to get more information about the
command. This is only applicable for HMP.
monitor.c | 92 ++++++++++++++++++++++++++++++++++++++-------------------------
1 file changed, 55 insertions(+), 37 deletions(-)
--
2.1.0
- [Qemu-devel] [PATCH v3 0/2] monitor: suggest running "help" for command errors,
Bandan Das <=
[Qemu-devel] [PATCH v3 2/2] When a command fails due to incorrect syntax or input, suggest using the "help" command to get more information about the command. This is only applicable for HMP., Bandan Das, 2015/05/27