Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI

[Markus Armbruster]

"Daniel P. Berrange" <address@hidden> writes:

> On Tue, May 26, 2015 at 02:51:45PM +0200, Gerd Hoffmann wrote:
>>   Hi,
>> 
>> > >> +#
>> > >> +# Set the spice/vnc connection info for the migration target.  The
>> > >> +# spice/vnc server will ask the spice/vnc client to automatically
>> > >> +# reconnect using the new parameters (if specified) once the vm
>> > >> +# migration finished successfully.  Not yet implemented for VNC.
>> > >> +#
>> > >> +# @protocol:     must be "spice"
>> > >> +# @hostname:     migration target hostname
>> > >> +# @port:         #optional spice/vnc tcp port for plaintext channels
>> > >
>> > > Is it worth documenting vnc, when we just stated earlier that protocol
>> > > must be spice?
>> > 
>> > I think this is a question for Gerd (cc'ed).
>> 
>> IIRC Daniel (added to Cc:) had plans to create a vnc extension for that.
>> 
>> Which was the reason to explicitly add the protocol here, so we can use
>> the same command for both spice and vnc some day.
>
> Yeah, it would be nice to do a VNC extension, though realistically I'm
> not going to have time for that anytime in the forseeable future.

Should we continue to document the command is about "spice/vnc
connection info", or should we rephrase?  Something like:

client_migrate_info
-------------------

Set remote display connection information for migration.  This makes the
server ask the client to automatically reconnect using the new
parameters once migration finished successfully.  Only implemented for
SPICE.

Arguments:

- "protocol":     must be "spice" (json-string)
- "hostname":     migration target hostname (json-string)
- "port":         spice/vnc tcp port for plaintext channels (json-int, optional)
- "tls-port":     spice tcp port for tls-secured channels (json-int, optional)
- "cert-subject": server certificate subject (json-string, optional)