Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI

[Gerd Hoffmann]

  Hi,

> >> +#
> >> +# Set the spice/vnc connection info for the migration target.  The
> >> +# spice/vnc server will ask the spice/vnc client to automatically
> >> +# reconnect using the new parameters (if specified) once the vm
> >> +# migration finished successfully.  Not yet implemented for VNC.
> >> +#
> >> +# @protocol:     must be "spice"
> >> +# @hostname:     migration target hostname
> >> +# @port:         #optional spice/vnc tcp port for plaintext channels
> >
> > Is it worth documenting vnc, when we just stated earlier that protocol
> > must be spice?
> 
> I think this is a question for Gerd (cc'ed).

IIRC Daniel (added to Cc:) had plans to create a vnc extension for that.

Which was the reason to explicitly add the protocol here, so we can use
the same command for both spice and vnc some day.

> >> +##
> >> +{ 'command': 'client_migrate_info',
> >> +  'data': { 'protocol': 'str', 'hostname': 'str', '*port': 'int',
> >> +            '*tls-port': 'int', '*cert-subject': 'str' } }
> >
> > Idea for followups - since 'protocol' must be "spice", should we:
> > 1) make it an enum type rather than open-coded str
> 
> Useful cleanup.

Agree.

> > 2) make it an optional parameter, so that omitting it defaults to spice?
> 
> Not sure.  Gerd?

Not sure this buys us much.  I guess libvirt will continue to pass
'spice' because everything else doesn't make much sense.

cheers,
  Gerd