Re: [Qemu-devel] [PATCH 0/4] More core code ENV_GET_CPU removals

[Peter Crosthwaite]

On Mon, May 25, 2015 at 6:08 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 25/05/2015 08:22, Peter Crosthwaite wrote:
>> Hi Andreas, Richard and all,
>>
>> I'm moving towards the goal of having no core code usages of ENV_GET_CPU.
>> This has two advantages:
>>
>> 1: It means we are closer to common-obj'ing core code like exec.c, cpus.c
>> and friends.
>> 2: Multi arch is easier if ENV_GET_CPU stays arch specific. It means I
>> don't need those patches where I reorder the env within the arch specific
>> CPUState. This allows continuing placement of arch specifics before the
>> env in the CPU container (which has TCG perf advantages).
>>
>> There's a couple more after this pack to get the multi-arch thing going,
>> but due to point 1, I'm sending this ahead as I think it has standalone 
>> value.
>>
>> Regards,
>> Peter
>>
>> Peter Crosthwaite (4):
>>   translate-all: Change tb_flush env argument to cpu
>>   gdbserver: _fork: Change fn to accept cpu instead of env
>>   cpus: Change tcg_cpu_exec arg to cpu, not env
>>   cpus: Change exec_init arg to cpu, not env
>>
>>  bsd-user/main.c             | 2 +-
>>  cpus.c                      | 7 +++----
>>  exec.c                      | 7 +++----
>>  gdbstub.c                   | 9 +++------
>>  include/exec/exec-all.h     | 4 ++--
>>  include/exec/gdbstub.h      | 2 +-
>>  linux-user/main.c           | 2 +-
>>  linux-user/signal.c         | 2 +-
>>  target-alpha/cpu.c          | 2 +-
>>  target-alpha/sys_helper.c   | 2 +-
>>  target-arm/cpu.c            | 2 +-
>>  target-cris/cpu.c           | 2 +-
>>  target-i386/cpu.c           | 2 +-
>>  target-i386/translate.c     | 2 +-
>>  target-lm32/cpu.c           | 2 +-
>>  target-m68k/cpu.c           | 2 +-
>>  target-microblaze/cpu.c     | 2 +-
>>  target-mips/cpu.c           | 2 +-
>>  target-moxie/cpu.c          | 2 +-
>>  target-openrisc/cpu.c       | 2 +-
>>  target-ppc/translate_init.c | 2 +-
>>  target-s390x/cpu.c          | 2 +-
>>  target-sh4/cpu.c            | 2 +-
>>  target-sparc/cpu.c          | 2 +-
>>  target-tricore/cpu.c        | 2 +-
>>  target-unicore32/cpu.c      | 2 +-
>>  target-xtensa/cpu.c         | 2 +-
>>  translate-all.c             | 6 ++----
>>  28 files changed, 36 insertions(+), 43 deletions(-)
>>
>
> Thanks, queued for 2.4.
>

Eduardo flagged a conflict with on-list work. Do you want me to handle it?

Regards,
Peter

> Paolo
>