[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] pc_init1: Don't misuse int for holding up a bool |
|
Date: |
Wed, 20 May 2015 09:30:11 -0300 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, May 20, 2015 at 11:55:53AM +0200, Paolo Bonzini wrote:
> On 20/05/2015 11:15, Michal Privoznik wrote:
> > When going through code I realized, that the pc_init1() has this two
> > arguments @pci_enabled and @kvmclock_enabled which despite used as
> > booleans are of int type.
> >
> > Signed-off-by: Michal Privoznik <address@hidden>
>
> Eduardo, do your patches to the PC machine types subsume this change?
Yes, it replaces the int function arguments with bool globals.
(Globals that will be eventually moved to PCMachineClass with the other
8 PC compat globals we have).
--
Eduardo