[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data()
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data() |
Date: |
Tue, 19 May 2015 16:39:12 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 05/19/2015 11:35 AM, Kevin Wolf wrote:
> Instead of relying on a flag in the MSR to distinguish controller phases,
> use the explicit phase that we store now. Assertions of the right MSR
> flags are added.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/block/fdc.c | 67
> ++++++++++++++++++++++++++++++++++------------------------
> 1 file changed, 39 insertions(+), 28 deletions(-)
>
> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index 4d4868e..a13e0ce 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
[snip]
Reviewed-by: John Snow <address@hidden>
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, (continued)
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, Peter Maydell, 2015/05/19
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, Kevin Wolf, 2015/05/20
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, Peter Maydell, 2015/05/20
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, Kevin Wolf, 2015/05/20
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, Peter Maydell, 2015/05/20
- Re: [Qemu-devel] [PATCH 3/8] fdc: Introduce fdctrl->phase, John Snow, 2015/05/20
[Qemu-devel] [PATCH 5/8] fdc: Code cleanup in fdctrl_write_data(), Kevin Wolf, 2015/05/19
[Qemu-devel] [PATCH 4/8] fdc: Use phase in fdctrl_write_data(), Kevin Wolf, 2015/05/19
[Qemu-devel] [PATCH 7/8] fdc: Fix MSR.RQM flag, Kevin Wolf, 2015/05/19
[Qemu-devel] [PATCH 6/8] fdc: Disentangle phases in fdctrl_read_data(), Kevin Wolf, 2015/05/19
[Qemu-devel] [PATCH 8/8] fdc-test: Test state for existing cases more thoroughly, Kevin Wolf, 2015/05/19