Re: [Qemu-devel] [PATCH 1/2] scripts: qom-*: add network syntax

[Eric Blake]

On 05/19/2015 08:12 AM, Martin Cerveny wrote:
> Hello.
> 
> On Tue, 19 May 2015, Eric Blake wrote:
>> On 05/19/2015 06:51 AM, Andreas Färber wrote:
>>> Am 13.05.2015 um 14:14 schrieb Martin Cerveny:
>>>> Add network syntax parsing (ip address, port) to qom-* scripts.
>>>>
>>>> Signed-off-by: Martin Cerveny <address@hidden>
>>>> ---
>>>>  scripts/qmp/qom-fuse |   13 ++++++++++++-
>>>>  scripts/qmp/qom-get  |   12 +++++++++++-
>>>>  scripts/qmp/qom-list |   12 +++++++++++-
>>>>  scripts/qmp/qom-set  |   12 +++++++++++-
>>>>  scripts/qmp/qom-tree |   12 +++++++++++-
>>>>  5 files changed, 56 insertions(+), 5 deletions(-)
>>>
>>> Could some Python guru please take a look at this?

>>>> +if len(connection) == 2:
>>>> +    try:
>>>> +         port = int(connection[1])
>>>> +    except ValueError:
>>>> +         raise QMPBadPort
>>>> +    connection = ( connection[0], port )
>>
>> Won't that mishandle IPv6 connections, such as something like [::1]:8000
>> for connecting to port 8000 on localhost, since it splits into more than
>> 2 pieces when splitting on :?
> 
> Yes, this is problem, but I copy-paste the same construct from
> scripts/qmp/qmp-shell to be compatible.

Might be worth mentioning that, as justification in the commit message.

> Is the IPv6 support for utilities mandatory ?

I don't have any strong feelings about it (I'm okay if you don't).  But
others might.

> If yes I can make V2.

If so, it would be good to fix qmp-shell, too - which makes it sound
like it would be a separate commit.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature