[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v7 10/11] vfio-pci: pass the aer error to guest
From: |
Chen Fan |
Subject: |
[Qemu-devel] [RFC v7 10/11] vfio-pci: pass the aer error to guest |
Date: |
Tue, 19 May 2015 12:42:52 +0800 |
when the vfio device encounters an uncorrectable error in host,
the vfio_pci driver will signal the eventfd registered by this
vfio device, the results in the qemu eventfd handler getting
invoked.
this patch is to pass the error to guest and have the guest driver
recover from the error.
Signed-off-by: Chen Fan <address@hidden>
---
hw/vfio/pci.c | 34 ++++++++++++++++++++++++++++------
1 file changed, 28 insertions(+), 6 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 61a348e..f2fc5d6 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3296,18 +3296,40 @@ static void vfio_put_device(VFIOPCIDevice *vdev)
static void vfio_err_notifier_handler(void *opaque)
{
VFIOPCIDevice *vdev = opaque;
+ PCIDevice *dev = &vdev->pdev;
+ PCIEAERMsg msg = {
+ .severity = 0,
+ .source_id = (pci_bus_num(dev->bus) << 8) | dev->devfn,
+ };
if (!event_notifier_test_and_clear(&vdev->err_notifier)) {
return;
}
+ /* we should read the error details from the real hardware
+ * configuration spaces, here we only need to do is signaling
+ * to guest an uncorrectable error has occurred.
+ */
+ if(dev->exp.aer_cap) {
+ uint8_t *aer_cap = dev->config + dev->exp.aer_cap;
+ uint32_t uncor_status;
+ bool isfatal;
+
+ uncor_status = vfio_pci_read_config(dev,
+ dev->exp.aer_cap + PCI_ERR_UNCOR_STATUS, 4);
+
+ isfatal = uncor_status & pci_get_long(aer_cap + PCI_ERR_UNCOR_SEVER);
+
+ msg.severity = isfatal ? PCI_ERR_ROOT_CMD_FATAL_EN :
+ PCI_ERR_ROOT_CMD_NONFATAL_EN;
+
+ pcie_aer_msg(dev, &msg);
+ return;
+ }
+
/*
- * TBD. Retrieve the error details and decide what action
- * needs to be taken. One of the actions could be to pass
- * the error to the guest and have the guest driver recover
- * from the error. This requires that PCIe capabilities be
- * exposed to the guest. For now, we just terminate the
- * guest to contain the error.
+ * If the aer capability is not exposed to the guest. we just
+ * terminate the guest to contain the error.
*/
error_report("%s(%04x:%02x:%02x.%x) Unrecoverable error detected. "
--
1.9.3
- [Qemu-devel] [RFC v7 03/11] qdev: add bus reset_notifiers callbacks for host bus reset, (continued)
- [Qemu-devel] [RFC v7 03/11] qdev: add bus reset_notifiers callbacks for host bus reset, Chen Fan, 2015/05/19
- [Qemu-devel] [RFC v7 08/11] vfio: add aer support for vfio device, Chen Fan, 2015/05/19
- [Qemu-devel] [RFC v7 06/11] vfio: add pcie extanded capability support, Chen Fan, 2015/05/19
- [Qemu-devel] [RFC v7 07/11] aer: impove pcie_aer_init to support vfio device, Chen Fan, 2015/05/19
- [Qemu-devel] [RFC v7 09/11] pcie_aer: expose pcie_aer_msg() interface, Chen Fan, 2015/05/19
- [Qemu-devel] [RFC v7 05/11] vfio: do hot bus reset when do virtual secondary bus reset, Chen Fan, 2015/05/19
- [Qemu-devel] [RFC v7 10/11] vfio-pci: pass the aer error to guest,
Chen Fan <=
- [Qemu-devel] [RFC v7 11/11] vfio: add 'aer' property to expose aercap, Chen Fan, 2015/05/19