[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/15] tap: Convert tap_set_sndbuf() to Error
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 07/15] tap: Convert tap_set_sndbuf() to Error |
Date: |
Fri, 15 May 2015 13:58:55 +0200 |
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
net/tap-aix.c | 3 +--
net/tap-bsd.c | 3 +--
net/tap-haiku.c | 3 +--
net/tap-linux.c | 6 ++----
net/tap-solaris.c | 3 +--
net/tap.c | 4 +++-
net/tap_int.h | 2 +-
7 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/net/tap-aix.c b/net/tap-aix.c
index 804d164..0a3d461 100644
--- a/net/tap-aix.c
+++ b/net/tap-aix.c
@@ -32,9 +32,8 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
return -1;
}
-int tap_set_sndbuf(int fd, const NetdevTapOptions *tap)
+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)
{
- return 0;
}
int tap_probe_vnet_hdr(int fd)
diff --git a/net/tap-bsd.c b/net/tap-bsd.c
index bf91bd0..53cdd9f 100644
--- a/net/tap-bsd.c
+++ b/net/tap-bsd.c
@@ -176,9 +176,8 @@ error:
}
#endif /* __FreeBSD__ */
-int tap_set_sndbuf(int fd, const NetdevTapOptions *tap)
+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)
{
- return 0;
}
int tap_probe_vnet_hdr(int fd)
diff --git a/net/tap-haiku.c b/net/tap-haiku.c
index e5ce436..0905b28 100644
--- a/net/tap-haiku.c
+++ b/net/tap-haiku.c
@@ -32,9 +32,8 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
return -1;
}
-int tap_set_sndbuf(int fd, const NetdevTapOptions *tap)
+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)
{
- return 0;
}
int tap_probe_vnet_hdr(int fd)
diff --git a/net/tap-linux.c b/net/tap-linux.c
index 812bf2d..6fa2744 100644
--- a/net/tap-linux.c
+++ b/net/tap-linux.c
@@ -126,7 +126,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
*/
#define TAP_DEFAULT_SNDBUF 0
-int tap_set_sndbuf(int fd, const NetdevTapOptions *tap)
+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)
{
int sndbuf;
@@ -139,10 +139,8 @@ int tap_set_sndbuf(int fd, const NetdevTapOptions *tap)
}
if (ioctl(fd, TUNSETSNDBUF, &sndbuf) == -1 && tap->has_sndbuf) {
- error_report("TUNSETSNDBUF ioctl failed: %s", strerror(errno));
- return -1;
+ error_setg_errno(errp, errno, "TUNSETSNDBUF ioctl failed");
}
- return 0;
}
int tap_probe_vnet_hdr(int fd)
diff --git a/net/tap-solaris.c b/net/tap-solaris.c
index 9c7278f..7839323 100644
--- a/net/tap-solaris.c
+++ b/net/tap-solaris.c
@@ -198,9 +198,8 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
return fd;
}
-int tap_set_sndbuf(int fd, const NetdevTapOptions *tap)
+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp)
{
- return 0;
}
int tap_probe_vnet_hdr(int fd)
diff --git a/net/tap.c b/net/tap.c
index 23c81fa..d54222d 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -610,7 +610,9 @@ static int net_init_tap_one(const NetdevTapOptions *tap,
NetClientState *peer,
TAPState *s = net_tap_fd_init(peer, model, name, fd, vnet_hdr);
int vhostfd;
- if (tap_set_sndbuf(s->fd, tap) < 0) {
+ tap_set_sndbuf(s->fd, tap, &err);
+ if (err) {
+ error_report_err(err);
return -1;
}
diff --git a/net/tap_int.h b/net/tap_int.h
index 79afdf2..6df271f 100644
--- a/net/tap_int.h
+++ b/net/tap_int.h
@@ -34,7 +34,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr,
ssize_t tap_read_packet(int tapfd, uint8_t *buf, int maxlen);
-int tap_set_sndbuf(int fd, const NetdevTapOptions *tap);
+void tap_set_sndbuf(int fd, const NetdevTapOptions *tap, Error **errp);
int tap_probe_vnet_hdr(int fd);
int tap_probe_vnet_hdr_len(int fd, int len);
int tap_probe_has_ufo(int fd);
--
1.9.3
- [Qemu-devel] [PATCH v2 00/15] net: Improve error reporting, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 01/15] net: Improve error message for -net hubport a bit, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 05/15] tap: net_tap_fd_init() can't fail, drop dead error handling, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 03/15] net: Improve -net nic error reporting, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 04/15] net/dump: Improve -net/host_net_add dump error reporting, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 14/15] tap: Finish conversion of tap_open() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 06/15] tap: Improve -netdev/netdev_add/-net/... bridge error reporting, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 02/15] net: Permit incremental conversion of init functions to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 11/15] tap-linux: Convert tap_open() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 07/15] tap: Convert tap_set_sndbuf() to Error,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 09/15] tap: Convert launch_script() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 12/15] tap-bsd: Convert tap_open() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 08/15] tap: Convert net_init_tap_one() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 10/15] tap: Permit incremental conversion of tap_open() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 13/15] tap-solaris: Convert tap_open() to Error, Markus Armbruster, 2015/05/15
- [Qemu-devel] [PATCH v2 15/15] tap: Improve -netdev/netdev_add/-net/... tap error reporting, Markus Armbruster, 2015/05/15
- Re: [Qemu-devel] [PATCH v2 00/15] net: Improve error reporting, Stefan Hajnoczi, 2015/05/19