[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 00/16] Fix qapi mangling of downstream names
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 00/16] Fix qapi mangling of downstream names |
Date: |
Thu, 14 May 2015 18:46:21 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/14/2015 06:50 AM, Eric Blake wrote:
>> This series makes it possible to use downstream extensions
>> (such as __com.redhat_xyz) and temporary names (such as x-foo)
>> in every position possible in QAPI schemes, with added tests
>> that the generated code still compiles.
>>
>> There's still some things we could do to the qapi generator,
>> such as normalizing struct member names and C manglings and
>> creating named implicit types up front on the initial parse
>> rather than multiple times in each backend. But that should
>> wait until existing pending patches have landed, to minimize
>> rebase churn.
>>
>> v3 was here:
>> https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00519.html
>> [already queued in Markus tree, but not yet in a pull request, so
>> that queue can be ruthlessly rebased]
>>
>> v4 includes 2 new patches (although 14/14 is somewhat unrelated,
>
> Make that 16/16 as the new patch that could be deferred to later (I was
> looking at the overall size of v3, while writing about v4)
>
>> and could easily be dropped from the series if it needs another
>> spin without holding up the rest of the series), incorporates
>> Markus' suggestions for more comments, and simplifies special-casing
>> of lists of builtin types.
Applied 01-15/16 to my qapi-next branch, left 16/16 for further review /
discussion, thanks!
- [Qemu-devel] [PATCH v4 01/16] qapi: Fix C identifiers generated for names containing '.', (continued)
- [Qemu-devel] [PATCH v4 01/16] qapi: Fix C identifiers generated for names containing '.', Eric Blake, 2015/05/14
- [Qemu-devel] [PATCH v4 09/16] qapi: Make c_type() consistently convert qapi names, Eric Blake, 2015/05/14
- [Qemu-devel] [PATCH v4 08/16] qapi: Tidy c_type logic, Eric Blake, 2015/05/14
- [Qemu-devel] [PATCH v4 06/16] qapi: Use c_enum_const() in generate_alternate_qtypes(), Eric Blake, 2015/05/14
- [Qemu-devel] [PATCH v4 07/16] qapi: Move camel_to_upper(), c_enum_const() to closely related code, Eric Blake, 2015/05/14
- Re: [Qemu-devel] [PATCH v4 00/16] Fix qapi mangling of downstream names, Eric Blake, 2015/05/14
- Re: [Qemu-devel] [PATCH v4 00/16] Fix qapi mangling of downstream names,
Markus Armbruster <=