[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector |
Date: |
Thu, 14 May 2015 12:02:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 14/05/2015 11:36, Michael S. Tsirkin wrote:
>
> There are three answers:
> 1. Yes, it's sure to get detected because everything gets shifted
> and then you get an unexpected string instead of next device name.
> 2. If you want a more generic way to detect this, then please work
> on changing format for devices generally so each device
> section has a byte length attached to it. Then we know that
> when we make changes, they are detected as device will end
> earlier/later than expected.
No need for that. Subsections were introduced exactly to allow a change
to be compatible in the common case and incompatible in the uncommon
case. Check out "git log -- grep subsection -- savevm.c".
> 3. You can have a different workaround: add property "skip config vec
> on migration" and set it for old spapr machine types.
> old types continue losing config vec; new ones work better.
Why in the world would you want that?
Paolo
- [Qemu-devel] [PATCH RFC 0/1] virtio: fix config_vector migration issues, Cornelia Huck, 2015/05/13
- [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Cornelia Huck, 2015/05/13
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/13
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Cornelia Huck, 2015/05/13
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/13
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Christian Borntraeger, 2015/05/13
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/13
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Christian Borntraeger, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Christian Borntraeger, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Dr. David Alan Gilbert, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Christian Borntraeger, 2015/05/15
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/15
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Cornelia Huck, 2015/05/18
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Cornelia Huck, 2015/05/18
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Paolo Bonzini, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Paolo Bonzini, 2015/05/14
- Re: [Qemu-devel] [PATCH RFC 1/1] virtio: migrate config_vector, Michael S. Tsirkin, 2015/05/14