[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 13/23] hw/acpi/aml-build: Make aml_buffer() defin
From: |
Shannon Zhao |
Subject: |
[Qemu-devel] [PATCH v7 13/23] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec |
Date: |
Thu, 14 May 2015 17:19:32 +0800 |
From: Shannon Zhao <address@hidden>
According to ACPI spec, DefBuffer can take two parameters: BufferSize
and ByteList. Make it consistent with the spec. If we want to request
uninitialized buffer, pass ByteList as NULL to aml_buffer() to
reserve spaces.
Signed-off-by: Shannon Zhao <address@hidden>
Signed-off-by: Shannon Zhao <address@hidden>
---
hw/acpi/aml-build.c | 15 ++++++++++++++-
include/hw/acpi/aml-build.h | 2 +-
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c
index b0e1dbc..6197896 100644
--- a/hw/acpi/aml-build.c
+++ b/hw/acpi/aml-build.c
@@ -636,9 +636,22 @@ Aml *aml_resource_template(void)
}
/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefBuffer */
-Aml *aml_buffer(void)
+Aml *aml_buffer(int buffer_size, uint8_t *byte_list)
{
+ int i;
Aml *var = aml_bundle(0x11 /* BufferOp */, AML_BUFFER);
+
+ for (i = 0; i < buffer_size; i++) {
+ /* (byte_list == NULL) means requesting uninitialized buffer, only
+ * need to reserve spaces.
+ */
+ if (byte_list == NULL) {
+ build_append_byte(var->buf, 0x0);
+ } else {
+ build_append_byte(var->buf, *(byte_list + i));
+ }
+ }
+
return var;
}
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index dd3b317..615f3c1 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -261,7 +261,7 @@ Aml *aml_device(const char *name_format, ...)
GCC_FMT_ATTR(1, 2);
Aml *aml_method(const char *name, int arg_count);
Aml *aml_if(Aml *predicate);
Aml *aml_package(uint8_t num_elements);
-Aml *aml_buffer(void);
+Aml *aml_buffer(int buffer_size, uint8_t *byte_list);
Aml *aml_resource_template(void);
Aml *aml_field(const char *name, AmlAccessType type, AmlUpdateRule rule);
Aml *aml_varpackage(uint32_t num_elements);
--
2.1.0
- [Qemu-devel] [PATCH v7 14/23] hw/acpi/aml-build: Add ToUUID macro, (continued)
[Qemu-devel] [PATCH v7 13/23] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec,
Shannon Zhao <=
[Qemu-devel] [PATCH v7 16/23] hw/acpi/aml-build: Add aml_lnot() term, Shannon Zhao, 2015/05/14
[Qemu-devel] [PATCH v7 22/23] ACPI: split CONFIG_ACPI into 4 pieces, Shannon Zhao, 2015/05/14
[Qemu-devel] [PATCH v7 23/23] hw/arm/virt: Enable dynamic generation of ACPI v5.1 tables, Shannon Zhao, 2015/05/14
[Qemu-devel] [PATCH v7 15/23] hw/acpi/aml-build: Add aml_or() term, Shannon Zhao, 2015/05/14
[Qemu-devel] [PATCH v7 21/23] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table, Shannon Zhao, 2015/05/14
Re: [Qemu-devel] [PATCH v7 00/23] Generate ACPI v5.1 tables and expose them to guest over fw_cfg on ARM, Peter Maydell, 2015/05/18