|
From: | Denis V. Lunev |
Subject: | Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page |
Date: | Mon, 11 May 2015 18:40:19 +0300 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 11/05/15 18:32, Eric Blake wrote:
On 05/11/2015 08:54 AM, Stefan Hajnoczi wrote:On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote:@@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp)raw_probe_alignment(bs, s->fd, errp);bs->bl.min_mem_alignment = s->buf_align; - bs->bl.opt_mem_alignment = s->buf_align; + if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment) + bs->bl.opt_mem_alignment = bs->bl.min_mem_alignment;QEMU coding style uses {} even when the if statement body is only one line.scripts/checkpatch.pl helps you check for this and other style issues.
yep, I have forgotten to run this before sending this time :(
[Prev in Thread] | Current Thread | [Next in Thread] |