qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to


From: Eric Blake
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: align bounce buffers to page
Date: Mon, 11 May 2015 09:32:37 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0

On 05/11/2015 08:54 AM, Stefan Hajnoczi wrote:
> On Mon, May 04, 2015 at 04:42:24PM +0300, Denis V. Lunev wrote:
>> @@ -726,7 +727,8 @@ static void raw_refresh_limits(BlockDriverState *bs, 
>> Error **errp)
>>  
>>      raw_probe_alignment(bs, s->fd, errp);
>>      bs->bl.min_mem_alignment = s->buf_align;
>> -    bs->bl.opt_mem_alignment = s->buf_align;
>> +    if (bs->bl.min_mem_alignment > bs->bl.opt_mem_alignment)
>> +        bs->bl.opt_mem_alignment = bs->bl.min_mem_alignment;
> 
> QEMU coding style uses {} even when the if statement body is only one
> line.

scripts/checkpatch.pl helps you check for this and other style issues.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]