[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure |
Date: |
Mon, 11 May 2015 16:21:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 08/05/2015 23:16, Corey Minyard wrote:
>>> >> + ipmi->intf = intf;
>>> >> + object_property_add_child(OBJECT(isadev), "intf", OBJECT(intf),
>>> >> errp);
>>> >> + if (*errp) {
>>> >> + return;
>>> >> + }
>>> >> + object_property_add_child(OBJECT(isadev), "bmc", OBJECT(bmc), errp);
>>> >> + if (*errp) {
>>> >> + return;
>>> >> + }
>>> >> +
>> > Should the created object be destroyed before return?
> Returning an error from the realize here appears to result in an error
> being printed and qemu being terminated, as far as I can tell. So it
> shouldn't matter here, right?
I would just use &error_abort and ignore error handling.
Paolo
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Corey Minyard, 2015/05/08
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Corey Minyard, 2015/05/08
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Andreas Färber, 2015/05/11
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Paolo Bonzini, 2015/05/11
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Corey Minyard, 2015/05/11
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Paolo Bonzini, 2015/05/13
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Corey Minyard, 2015/05/15
- Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure, Paolo Bonzini, 2015/05/16