[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] migration: move ram stuff to migration/ram
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] migration: move ram stuff to migration/ram |
Date: |
Fri, 08 May 2015 08:11:17 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 |
On 05/08/2015 06:43 AM, Juan Quintela wrote:
> For historic reasons, ram migration have been on arch_init.c. Just
s/have been on/has been in/
> split it into migration/ram.c, the same that happened with block.c.
>
> There is only code movement, no changes altogether.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> MAINTAINERS | 1 -
> Makefile.target | 1 +
> arch_init.c | 1754
> ++---------------------------------------
> include/migration/migration.h | 2 +
> include/sysemu/arch_init.h | 1 -
> migration/ram.c | 1681 +++++++++++++++++++++++++++++++++++++++
> trace-events | 2 +-
> 7 files changed, 1747 insertions(+), 1695 deletions(-)
> create mode 100644 migration/ram.c
This diff is harder than necessary to read. It can be made smaller by
using the --patience argument when creating the diff:
$ git diff HEAD^ --patience --stat
MAINTAINERS | 1 -
Makefile.target | 1 +
arch_init.c | 1630
---------------------------------------
include/migration/migration.h | 2 +
include/sysemu/arch_init.h | 1 -
migration/ram.c | 1681
+++++++++++++++++++++++++++++++++++++++++
trace-events | 2 +-
7 files changed, 1685 insertions(+), 1633 deletions(-)
To make it permanent:
$ git config diff.algorithm patience
At any rate, here's how I reviewed:
$ diff -u <(git diff HEAD^ | sed -n 's/^-//p') <(git diff HEAD^ | sed -n
's/^\+//p')
You introduced a newline before mig_sleep_cpu(), and changed the text in
the DPRINTF definition, but I can live with that.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature