Re: [Qemu-devel] [PATCH v3 0/7] qom: misc fixes & enhancements to support TLS work

[Andreas Färber]

Am 05.05.2015 um 12:33 schrieb Paolo Bonzini:
> 
> 
> On 01/05/2015 12:29, Daniel P. Berrange wrote:
>> This series contains the 7 generic QOM API fixes and enhancements
>> that I previously posted as part of the large series refactoring
>> and extending the TLS support in QEMU:
>>
>>   https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg02038.html
>>
>> I'm sending it separately, since the patches are reasonably well
>> self-contained and thus hopefully suitable for quicker review and
>> merge.
>>
>> Changed in v3:
>>
>>  - Fix test suite additions for change in object_new_propv API
>>
>> Changed in v2:
>>
>>  - Pass "Object * parent" instead of "char *path" paremeter
>>  - Rely on stable reference from parent to keep new object alive
>>  - Use object_unparent() where appropriate
>>
>> Daniel P. Berrange (7):
>>   qom: fix typename of 'policy' enum property in hostmem obj
>>   qom: document user creatable object types in help text
>>   qom: create objects in two phases
>>   qom: add object_new_propv / object_new_proplist constructors
>>   qom: make enum string tables const-correct
>>   qom: add a object_property_add_enum helper method
>>   qom: don't pass string table to object_get_enum method
>>
>>  backends/hostmem.c          |  22 ++--
>>  include/hw/qdev-core.h      |   2 +-
>>  include/qapi/util.h         |   2 +-
>>  include/qapi/visitor-impl.h |   6 +-
>>  include/qapi/visitor.h      |   2 +-
>>  include/qom/object.h        |  90 ++++++++++++-
>>  numa.c                      |   2 +-
>>  qapi/qapi-dealloc-visitor.c |   3 +-
>>  qapi/qapi-util.c            |   2 +-
>>  qapi/qapi-visit-core.c      |   6 +-
>>  qemu-options.hx             |  70 +++++++---
>>  qom/object.c                | 144 +++++++++++++++++++-
>>  scripts/qapi-types.py       |   4 +-
>>  tests/.gitignore            |   1 +
>>  tests/Makefile              |   5 +-
>>  tests/check-qom-proplist.c  | 310 
>> ++++++++++++++++++++++++++++++++++++++++++++
>>  vl.c                        |  40 +++++-
>>  17 files changed, 661 insertions(+), 50 deletions(-)
>>  create mode 100644 tests/check-qom-proplist.c
>>
> 
> Thanks, queued for 2.4.

Objection. None of the QOM patches have been reviewed by me and you knew
I would be back today.

Andreas

> 
> Paolo
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)