[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send |
Date: |
Thu, 30 Apr 2015 12:32:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
On 30/04/2015 10:59, Jason Wang wrote:
>>
>>
>> + /* If !can_send, we will want to disable the read poll, but
>> we still
>> + * need the send completion callback to enable it again,
>> which is a
>> + * sign of peer becoming ready. So call the send function
>> + * regardlessly of can_send.
>> + */
>
> It was probably not safe to depend on sent_cb to re-enable the polling.
> Since the packet could be purged in some conditions (e.g
> net_vm_change_state_handler()). So tap_send_completed won't be called in
> this case.
Doesn't qemu_net_queue_purge also call the sent_cb?
Paolo
- [Qemu-devel] [RFC PATCH 2/8] qemu-nbd: Switch to qemu_set_fd_handler, (continued)
- [Qemu-devel] [RFC PATCH 2/8] qemu-nbd: Switch to qemu_set_fd_handler, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 1/8] stubs: Add qemu_set_fd_handler, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 4/8] netmap: Drop netmap_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 3/8] l2tpv3: Drop l2tpv3_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 5/8] net/socket: Drop net_socket_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 7/8] Change qemu_set_fd_handler2(..., NULL, ...) to qemu_set_fd_handler, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 6/8] tap: Drop tap_can_send, Fam Zheng, 2015/04/29
- [Qemu-devel] [RFC PATCH 8/8] main-loop: Drop qemu_set_fd_handler2, Fam Zheng, 2015/04/29